Fix iso format for v3 in cert-tool

yosuke · February 20, 2021, 9:00pm

I just found the problem of iso_format between cert_tool and cert_issuer in V3.

When I tried to issue the template that I created with cert_tool, I got the format error because the value of “issueOn” did not match the method validated below.

github.com

blockchain-certificates/cert-issuer/blob/37399da56508dba073abea0f759b4157d0830cd5/cert_issuer/models.py#L7


import re
from urllib.parse import urlparse
from abc import abstractmethod
from cert_issuer.config import ESTIMATE_NUM_INPUTS
def validate_RFC3339_date (date):
    return re.match('^[1-9]\d{3}-\d{2}-\d{2}[Tt]\d{2}:\d{2}:\d{2}[Zz]$', date)
def validate_url (url):
    parsed_url = urlparse(url)
    is_valid_url = (not (parsed_url.path.__contains__(' ')
        or parsed_url.netloc.__contains__(' '))
        and url.__contains__(':'))
    if not is_valid_url:
        raise ValueError('Invalid URL: {}'.format(url))

And this is from cert-tool.

github.com

blockchain-certificates/cert-tools/blob/a943755aafda6ba8239f1309bdcdfc71e599f07f/cert_tools/helpers.py#L59


        return alphabet[0]
    arr = []
    base = len(alphabet)
    while num:
        num, rem = divmod(num, base)
        arr.append(alphabet[rem])
    arr.reverse()
    return ''.join(arr)
def create_iso8601_tz():
    ret = datetime.now(timezone.utc)
    return ret.isoformat()

Hence, I just send the PR for cert-tool to adjust for cert-issuer’s validater as the proposal.

if there is any better way than this one, just let me know!!

lemoustachiste · February 24, 2021, 2:10pm

Thanks for your contribution, I have noticed the build fails on a tox instruction so I’m trying to sort that out.

Topic		Replies	Views
Cert-tools error: AttributeError: 'str' object has no attribute 'isoformat'. Did you mean: 'format'?	7	2465	October 29, 2023
Getting an error when i try to instantiate_certificate_batch.py in cert_tools repo Technical	1	352	July 5, 2023
Cert-tools Error Support	7	1072	October 29, 2023
Cert_issuer problem in bitcoin testnet (models.py) Support	8	865	February 8, 2022
Cert verifier stuck at format validation Support	3	871	June 28, 2018

Fix iso format for v3 in cert-tool

Related topics